Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [activityDiagram] missing no-action-line parentId caused layout problem #271

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

hikerpig
Copy link
Owner

Related #265

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pintorajs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 15, 2024 0:30am

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.79%. Comparing base (87f80b1) to head (c6afc81).
Report is 146 commits behind head on master.

Files Patch % Lines
packages/pintora-diagrams/src/activity/artist.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage   91.06%   91.79%   +0.73%     
==========================================
  Files          69       88      +19     
  Lines        3994     5155    +1161     
  Branches      762      912     +150     
==========================================
+ Hits         3637     4732    +1095     
- Misses        357      423      +66     
Flag Coverage Δ
unittests 91.79% <50.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hikerpig hikerpig merged commit 651b22c into master Mar 15, 2024
9 of 12 checks passed
@hikerpig hikerpig deleted the fix-activity-strange-corner branch March 15, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant