Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make showConnect not persist, less breaking #349

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Dec 8, 2023

This PR was published to npm with the alpha versions:

@beguene I added a small tweak, that will not persist the selection for the authenticate method, but only for the newly added methods. This way the recent Connect commit is not a "breaking change".

  • Introduces the persistSelection boolean, to let users have the selection dialog always appear

@janniks janniks requested a review from beguene December 8, 2023 12:40
Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: f84e183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview Dec 8, 2023 0:40am
connect-docs ✅ Ready (Inspect) Visit Preview Dec 8, 2023 0:40am

Copy link
Contributor

@beguene beguene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea ! Code looks good !
:shipit:

@janniks janniks merged commit e408293 into main Dec 8, 2023
8 checks passed
@janniks janniks deleted the refactor/update-authenticate-to-not-persist branch December 8, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants