Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor update stackstransaction constructor to options object #1751

Open
wants to merge 5 commits into
base: 10-23-refactor_remove_unneeded_deserialize_overloads
Choose a base branch
from
Open

refactor update stackstransaction constructor to options object #1751

wants to merge 5 commits into from
+291 −237

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 23, 2024 •
edited by github-actions bot
Loading

This PR was published to npm with the version 6.14.1-pr.87+5ed8a666
e.g. npm install @stacks/[email protected]+5ed8a666 --save-exact

  • Rename StacksTransaction, so we can use the name for a better more human readable alternative in the future
  • Update to accept an options object instead

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 3:15pm

@codecov Codecov
Copy link

codecov bot commented Oct 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.04651% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/authorization.ts 82.35% 3 Missing ⚠️
packages/transactions/src/builders.ts 76.92% 3 Missing ⚠️
packages/transactions/src/signer.ts 50.00% 2 Missing ⚠️
packages/cli/src/cli.ts 0.00% 1 Missing ⚠️
packages/stacking/src/index.ts 0.00% 1 Missing ⚠️
packages/transactions/src/postcondition.ts 85.71% 1 Missing ⚠️
packages/transactions/src/transaction.ts 96.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks requested a review from beguene October 23, 2024 16:12
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from c0ef9c2 to 4db76a6 Compare October 23, 2024 19:43
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from 54c8722 to 9e99ed7 Compare October 23, 2024 19:43
beguene
beguene approved these changes Oct 24, 2024
View reviewed changes
packages/transactions/src/postcondition-types.ts
@@ -40,3 +40,5 @@ export type NonFungiblePostCondition = {
};

export type PostCondition = StxPostCondition | FungiblePostCondition | NonFungiblePostCondition;

export type PostConditionModeName = 'allow' | 'deny';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 4db76a6 to 8a72ccb Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_update_stackstransaction_constructor_to_options_object branch from 7144c1b to 5ed8a66 Compare October 24, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beguene beguene beguene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janniks @beguene