This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Resolve complation issues with -fno-common (default from gcc-10) #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-m` was added as short option for `--no-mouse`, this is inconsistence to the rest of the cli since otherwise the short options to disable a feature are capital letters. Therefore this commit renames the option to `-M`. This commit also documents the option in the man page.
v is generally used for enabling verbose mode
Compatible with gcc and clang.
Use internal macros for compatibility with non GNUC compilers.
int foo(); declares a function taking any number of arguments.
These feature macros are either define or not defined at all at the configure step.
They are nowhere used.
This also fixes an issue with time returned negative if sysconf(_SC_CLK_TCK) returned an error.
The check for NAN is kept to avoid relying on implementation details of the CLAMP macro/function
If currently two unsigned values are compared via `a - b`, in the case b
is actually bigger than a, the result will not be an negative number (as
-1 is expected) but a huge positive number as the subtraction is an
unsigned subtraction.
Avoid over-/underflow affected operations; use comparisons.
Modern compilers will generate sane code, like:
xor eax, eax
cmp rdi, rsi
seta al
sbb eax, 0
ret
It is only used to read process directories on RedHat beginning with a dot. Unconditionally accept directories with a starting dot.
Shows the process CPU usage divided by the number of CPU cores
- use consistent type for key by introducing a new typedef - use unsigned types for sizes - name parameters in foreach function typedef
Dynamically increase the hashmap size to not exceed the load factor and avoid too long chains. Switch from Separate Chaining to Robin Hood linear probing to improve cache locality. Use primes as size to further avoid collisions. E.g. on a standard kde system the number of entries in the ProcessTable might be around 650.
Consistent with everything else involving platform-specific calls from core htop code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the MakeHeader script to auto-generate correct "extern"
function declarations in some cases that it currently does not.
Related to #981