Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requirements #6

Open
wants to merge 1 commit into
base: dev2
Choose a base branch
from
Open

Conversation

trungnt2910
Copy link

Description

Type of change: bug fix

What

What does the PR do?

Fix requirements.

  • Added websocket-client requirement
  • Restrict django-admin-sortable2 to <2, as version 2 and later requires Django 4.

Why

Why this PR is needed?
To prevent headaches from other developers when setting up the server.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested on my local environment (Python 3.8, Ubuntu 20.04 WSL 1).

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have explained the purpose of this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the README/documentation
  • Any dependent changes have been merged and published in downstream modules
  • Informed of breaking changes, testing and migrations (if applicable).
  • Attached screenshots (if applicable).

By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.

- Added websocket-client requirement
- Restrict django-admin-sortable2 to <2, as version 2
and later requires Django 4.
- Restrict bleach to <5. Version 5 has breaking changes
that break jinja2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant