feat: add cli option to read note from stdin #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like in "add" command Signed-off-by: Oliver Lippert <[email protected]>
MohamedBassem
requested changes
Oct 19, 2024
| @@ -187,13 +187,19 @@ bookmarkCmd | |||
| .description("update a bookmark") | |||
| .option("--title <title>", "if set, the bookmark's title will be updated") | |||
| .option("--note <note>", "if set, the bookmark's note will be updated") | |||
| .option("--stdin", "if set, the bookmark's note will be updated by stdin (not to be used with --note)") | |||
There was a problem hiding this comment.
Can we give the flag a better name to indicate that it's updating the notes? Maybe --note-stdin or something?
There was a problem hiding this comment.
Indeed I wondered about --stdin for add parameter as well. It's unclear what it's for. But I decided to be consistent. I'ld suggest to rename --stdin for both commands after the merge? Or rename it in parallel and I'll update + adapbt before merging this PR?
Signed-off-by: Oliver Lippert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CLI option
--stdinthat works like it is implemented in theaddcommand: Instead of from--note <NOTE>the note's content is read from stdin.This way something like
cat some-long-note.txt | hoarder bookmarks update --stdin <ID>can work