feature: Recrawl failed links #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AhmadMuj
commented
Apr 11, 2024
AhmadMuj
commented
- Added a backoff for the Links Crawler Queue
- Added a new field in ( crawStatus ) in the bookmarkLinks table
- Added a new button the web to recrawl the failed URLs based on the crawStatus
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MohamedBassem
requested changes
Apr 11, 2024
Comment on lines
184
to
174
| <TableRow> | ||
| <TableCell className="lg:w-2/3">Failed Crawling Jobs</TableCell> | ||
| <TableCell>{serverStats.failedCrawls}</TableCell> | ||
| </TableRow> |
There was a problem hiding this comment.
How about we change the table to be a bit more 2d?
As in:
| Pending | Failed | |
|---|---|---|
| Crawling jobs | 0 | 0 |
| Inference jobs | 0 | 0 |
| Search jobs | 0 | - |
There was a problem hiding this comment.
For now the indexing and openai are going to be based off the queue status.
packages/trpc/routers/admin.ts
Outdated
| @@ -59,7 +69,21 @@ export const adminAppRouter = router({ | |||
| ), | |||
| ); | |||
| }), | |||
|
|
|||
| recrawlFailedLinks: adminProcedure.mutation(async ({ ctx }) => { | |||
There was a problem hiding this comment.
It seems that we can easily add a onlyFailures in the existing recrawlAllLinks instead of creating a new endpoint?
Comment on lines
+2
to
+3
| UPDATE bookmarkLinks SET crawlStatus = 'failure' where htmlContent is null;--> statement-breakpoint | ||
| UPDATE bookmarkLinks SET crawlStatus = 'success' where htmlContent is not null; |
|
Thanks again, I'm pretty sure a lot of people will find this to be super useful! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.