Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track barometer's request times #9

Open
msaspence opened this issue Jul 22, 2016 · 2 comments
Open

Track barometer's request times #9

msaspence opened this issue Jul 22, 2016 · 2 comments
Assignees
Labels

Comments

@msaspence
Copy link

msaspence commented Jul 22, 2016

If we track barometer's own request times and add it to the next payload we can get some idea of how much impact those requests are likely to have on the host application's requests.

This is implemented in Bucky we can probably lift it out of there.

@theninj4
Copy link
Contributor

This is an interesting one. We've tried to mitigate the impact on the running application to the extent that we either get the metrics, or the metrics get dropped. This could be an interesting-to-have, but it also might require more code than we'd like. There may be more valuable features to squeeze in for a similar byte addition.

@msaspence
Copy link
Author

This doesn't just give us barometers request time but since we immediately respond with 200 it gives us latency too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants