Track barometer request times #22
Closed
+5,562
−5,560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,7 +56,7 @@ transport._flushBuffer = function (pageEnd) { | |||
| if (navigator.sendBeacon) { | |||
| navigator.sendBeacon(url, JSON.stringify(bufferToSend)) | |||
| } else { | |||
| var xhr = new xhrStats._XMLHttpRequest() | |||
| var xhr = new window.XMLHttpRequest() | |||
There was a problem hiding this comment.
The challenge with doing this the HTTP request to store metrics will generate more and more metrics. We'll end up in an infinite cycle of HTTP requests. If you try this by dumping the built code into this TripApp PR (https://github.com/holidayextras/tripapplite/pull/4190) you'll see the constant flow of metrics, even when no page interactions are happening.
slavcho-slavchev-hx
force-pushed
the
track-barometer-request-times
branch
from
4b8a178
to
668a053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #9. We already measure the times for all GET requests but the POST request that barometer makes is using the real XmlHttpRequest and doesn't log the times. I just made the change to use the monkey-patched version we have so that it would log the metrics.