only check ip country == document country if ipCountry exists in docu…

…ment
holonym-foundation · May 10, 2024 · e088fe7 · e088fe7
1 parent 4b85052
commit e088fe7
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/src/services/idenfy/credentials.js b/src/services/idenfy/credentials.js
@@ -95,7 +95,10 @@ function validateSession(metaSession, statusData, verificationData, scanRef) {
       },
     };
   }
-  if (countryCode != countryCodeToPrime[metaSession.ipCountry]) {
+  // if !metaSession.ipCountry, then the session was created before we added
+  // the ipCountry attribute. Because this is only ~3k sessions and to reduce tickets, 
+  // we can ignore this check for such sessions.
+  if (metaSession.ipCountry && (countryCode != countryCodeToPrime[metaSession.ipCountry])) {
     return {
       error: `Country code mismatch. Session country is '${metaSession.ipCountry}', but document country is '${country}'. scanRef: ${scanRef}`,
       log: {

diff --git a/src/services/onfido/credentials.js b/src/services/onfido/credentials.js
@@ -97,7 +97,10 @@ function validateReports(reports, metaSession) {
           },
         };
       }
-      if (countryCodeToPrime[report.properties.issuing_country] != countryCodeToPrime[metaSession.ipCountry]) {
+      // if !metaSession.ipCountry, then the session was created before we added
+      // the ipCountry attribute. Because this is only ~3k sessions and to reduce tickets, 
+      // we can ignore this check for such sessions.
+      if (metaSession.ipCountry && (countryCodeToPrime[report.properties.issuing_country] != countryCodeToPrime[metaSession.ipCountry])) {
         return {
           error: `Country code mismatch. Session country is '${metaSession.ipCountry}', but document country is '${report.properties.issuing_country}'.`,
           log: {

diff --git a/src/services/veriff/credentials.js b/src/services/veriff/credentials.js
@@ -114,7 +114,10 @@ function validateSession(session, metaSession) {
       },
     };
   }
-  if (countryCode != countryCodeToPrime[metaSession.ipCountry]) {
+  // if !metaSession.ipCountry, then the session was created before we added
+  // the ipCountry attribute. Because this is only ~3k sessions and to reduce tickets, 
+  // we can ignore this check for such sessions.
+  if (metaSession.ipCountry && (countryCode != countryCodeToPrime[metaSession.ipCountry])) {
     return {
       error: `Country code mismatch. Session country is '${metaSession.ipCountry}', but document country is '${session?.verification?.document?.country}'.`,
       log: {