Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open apps in new tab #1367

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat: open apps in new tab #1367

wants to merge 4 commits into from

Conversation

hillaliy
Copy link
Contributor

@hillaliy hillaliy commented Oct 24, 2024


Homarr

Thank you for your contribution. Please ensure that your pull request meets the following pull request:

  • Builds without warnings or errors (pnpm buid, autofix with pnpm format:fix)
  • Pull request targets dev branch
  • Commits follow the conventional commits guideline
  • No shorthand variable names are used (eg. x, y, i or any abbrevation)

@hillaliy hillaliy self-assigned this Oct 24, 2024
@hillaliy hillaliy added the enhancement New feature or request label Oct 24, 2024
Copy link

deepsource-io bot commented Oct 24, 2024

Here's the code health analysis summary for commits 0aa72d1..db0c3bb. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

github-actions bot commented Oct 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 17.94% 5671 / 31599
🔵 Statements 17.94% 5671 / 31599
🔵 Functions 22.7% 233 / 1026
🔵 Branches 52.58% 559 / 1063
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/nextjs/src/app/[locale]/manage/apps/page.tsx 0% 0% 0% 0% 1-120
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/page.tsx 0% 0% 0% 0% 1-125
apps/nextjs/src/app/[locale]/manage/users/[userId]/general/_components/_open-apps-in-new-tab.tsx 0% 0% 0% 0% 1-64
packages/api/src/router/user.ts 23.85% 40% 50% 23.85% 25-29, 32-45, 48-70, 78-81, 97-132, 150-158, 162-168, 179-192, 196-225, 229-265, 269-276, 279-338, 343-371, 374-379, 382-394, 400-412, 415-427, 433-459, 462-474, 480-492, 510-511, 514-530
packages/db/schema/mysql.ts 100% 100% 100% 100%
packages/db/schema/sqlite.ts 100% 100% 100% 100%
packages/spotlight/src/modes/app-integration-board/apps-search-group.tsx 0% 0% 0% 0% 1-103
packages/translation/src/lang/en.ts 0% 0% 0% 0% 1-2518
packages/validation/src/user.ts 100% 100% 100% 100%
Generated in workflow #3632 for commit db0c3bb by the Vitest Coverage Report Action

@hillaliy hillaliy marked this pull request as ready for review November 8, 2024 09:39
@hillaliy hillaliy requested a review from a team as a code owner November 8, 2024 09:39
@manuel-rw
Copy link
Member

Please provide some screenshots

@hillaliy
Copy link
Contributor Author

hillaliy commented Nov 8, 2024

I have problem to change to this branch, because it's add column on DB.
This PR just add another option on user settings like Accessibility to open apps from search bar and from management in new tab.
Screenshot 2024-11-08 at 22 54 25

@manuel-rw
Copy link
Member

I have problem to change to this branch, because it's add column on DB. This PR just add another option on user settings like Accessibility to open apps from search bar and from management in new tab. Screenshot 2024-11-08 at 22 54 25

Can you post in our internal chat? Then we can help you sooner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants