Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused properties in SabNZBd schema #1415

Merged
merged 2 commits into from
Nov 10, 2024
Merged

fix: remove unused properties in SabNZBd schema #1415

merged 2 commits into from
Nov 10, 2024

Conversation

SeDemal
Copy link
Collaborator

@SeDemal SeDemal commented Nov 3, 2024

fixes: #1414

@SeDemal SeDemal requested a review from a team as a code owner November 3, 2024 22:20
@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Nov 3, 2024 •
edited
Loading

Here's the code health analysis summary for commits aec9ec1..d33882e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.04% 6374 / 28911
🔵 Statements 22.04% 6374 / 28911
🔵 Functions 24.02% 246 / 1024
🔵 Branches 60.35% 772 / 1279
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/integrations/src/download-client/sabnzbd/sabnzbd-schema.ts 100% 100% 100% 100%
Generated in workflow #3640 for commit d33882e by the Vitest Coverage Report Action

@SeDemal
Copy link
Collaborator Author

SeDemal commented Nov 4, 2024

@manuel-rw if you test it real quick, knowing them there might be something else needing to be changed, and if so I need to investigate more

@SeDemal SeDemal changed the title fix: Add boolean to retry entry for sabnzbd history schema fix: Remove useless entries in SabNZBd schema Nov 10, 2024
@Meierschlumpf Meierschlumpf changed the title fix: Remove useless entries in SabNZBd schema fix: remove unused entries in SabNZBd schema Nov 10, 2024
@Meierschlumpf Meierschlumpf changed the title fix: remove unused entries in SabNZBd schema fix: remove unused properties in SabNZBd schema Nov 10, 2024
@Meierschlumpf Meierschlumpf added the bug Something isn't working label Nov 10, 2024
@Meierschlumpf Meierschlumpf dismissed manuel-rw’s stale review November 10, 2024 09:31

Requested changes were performed

@Meierschlumpf Meierschlumpf merged commit ceafd37 into dev Nov 10, 2024
14 checks passed
@Meierschlumpf Meierschlumpf deleted the fix/sabnzbd-schema-history-retry branch November 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meierschlumpf Meierschlumpf Meierschlumpf approved these changes

@manuel-rw manuel-rw Awaiting requested review from manuel-rw

Assignees

@SeDemal SeDemal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: invalid_type zod sabnzbd
3 participants
@SeDemal @manuel-rw @Meierschlumpf