feat: add more group permissions #1453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the code health analysis summary for commits Analysis Summary
|
Meierschlumpf
force-pushed
the
more-group-permissions
branch
from
9d85642
to
a960002
Compare
manuel-rw
requested changes
Nov 11, 2024
| @@ -95,27 +98,32 @@ export default async function ManageLayout({ children }: PropsWithChildren) { | |||
| { | |||
| label: t("items.tools.label"), | |||
| icon: IconTool, | |||
| hidden: !session?.user.permissions.includes("admin"), | |||
| // As permissions always include there children permissions, we can check for the lowest permission | |||
There was a problem hiding this comment.
I understand what you mean but "low" is in my opinion a poor word choice to describe it (eg. what is high?)
| }; | ||
|
|
||
| export const catchTrpcUnauthorized = (err: unknown) => { | ||
| if (err instanceof TRPCError && err.code === "UNAUTHORIZED") { |
There was a problem hiding this comment.
Should we log this? I'd say say as "info"
Comment on lines
+40
to
+46
| if (item.kind === "app") { | ||
| const parsedOptions = SuperJSON.parse<WidgetComponentProps<"app">["options"]>(item.options); | ||
| return [parsedOptions.appId]; | ||
| } else if (item.kind === "bookmarks") { | ||
| const parsedOptions = SuperJSON.parse<WidgetComponentProps<"bookmarks">["options"]>(item.options); | ||
| return parsedOptions.items; | ||
| } |
There was a problem hiding this comment.
I dislike non-generic special cases.
For the app it's fine but is there maybe a better option / more generic way for the bookmark? (eg. by checking type of options?)
| return parsedOptions.items; | ||
| } | ||
|
|
||
| throw new Error("Invalid item kind"); |
There was a problem hiding this comment.
Not descriptive enough. It says what is wrong but not what happened.
Suggestion: Failed to get app ids from board. Invalid item kind: 'test'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homarr
Thank you for your contribution. Please ensure that your pull request meets the following pull request:
pnpm buid, autofix withpnpm format:fix)devbranchx,y,ior any abbrevation)Closes #1240