Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiofiles to package constraints #127749

Closed
wants to merge 2 commits into from
Closed

Conversation

silamon
Copy link
Contributor

@silamon silamon commented Oct 6, 2024

Proposed change

Some (popular) custom integration https://github.com/UI-Lovelace-Minimalist/UI pinned aiofiles to 0.8.0, which has no support for python 3.12. Adding this library to package constraints as a temporary workaround. See #126904 for more information. There are 8 core integrations that rely on this library.

PR at the custom integration: UI-Lovelace-Minimalist/UI#1543

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@autinerd
Copy link
Contributor

autinerd commented Oct 6, 2024

Please run the gen_requirements_all script.

@silamon silamon requested a review from a team as a code owner October 6, 2024 17:43
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a new constraint, couldn't we just add the custom integration to the block list here?

BLOCKED_CUSTOM_INTEGRATIONS: dict[str, BlockedIntegration] = {
# Added in 2024.3.0 because of https://github.com/home-assistant/core/issues/112464
"start_time": BlockedIntegration(AwesomeVersion("1.1.7"), "breaks Home Assistant"),

@home-assistant home-assistant bot marked this pull request as draft October 6, 2024 18:14
@home-assistant
Copy link

home-assistant bot commented Oct 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@cdce8p cdce8p added this to the 2024.10.2 milestone Oct 6, 2024
@silamon
Copy link
Contributor Author

silamon commented Oct 7, 2024

Instead of adding a new constraint, couldn't we just add the custom integration to the block list here?

BLOCKED_CUSTOM_INTEGRATIONS: dict[str, BlockedIntegration] = {
# Added in 2024.3.0 because of https://github.com/home-assistant/core/issues/112464
"start_time": BlockedIntegration(AwesomeVersion("1.1.7"), "breaks Home Assistant"),

It doesn't crash or cause any performance issues atm. I don't think it's right to take out the bazooka for this one.

@cdce8p
Copy link
Member

cdce8p commented Oct 7, 2024

It doesn't crash or cause any performance issues atm. I don't think it's right to take out the bazooka for this one.

But isn't the result similar? With either method the custom integration will fail to install. Either because of the check for blocked integrations or because the requirements don't match our constraints. Better to have a good error message then.

@silamon
Copy link
Contributor Author

silamon commented Oct 10, 2024

I'm going to close this one, since I don't think it appropriate to block a custom integration at this moment.

@silamon silamon closed this Oct 10, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linkplay, cannot set up Wiim Pro Plus - AttributeError: '_io.TextIOWrapper' object has no attribute 'delete'
3 participants