Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AFPacket source #154

Closed
wants to merge 22 commits into from
Closed

feat: Add AFPacket source #154

wants to merge 22 commits into from

Conversation

MikeGoldsmith
Copy link
Contributor

Which problem is this PR solving?

Adds AFPacket as a new new packet capture source.

Short description of the changes

  • Add new AFPacket handle that can be used by setting packet source config value to "afpacket"
  • Add new buffer size config option

How to verify that this has the expected result

AFPacket can be used as the capture source when packetsource config option is set.

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Sep 7, 2023
@MikeGoldsmith MikeGoldsmith self-assigned this Sep 7, 2023
@MikeGoldsmith MikeGoldsmith requested a review from a team September 7, 2023 13:41
@robbkidd
Copy link
Member

@MikeGoldsmith do you think it's worth reimplementing this in a new branch against latest main? There's been a bunch of changes!

@robbkidd robbkidd added the status: info needed Further information is requested. label Sep 20, 2023
@MikeGoldsmith
Copy link
Contributor Author

@MikeGoldsmith do you think it's worth reimplementing this in a new branch against latest main? There's been a bunch of changes!

Yep, I'll update to resolve conflicts.

@MikeGoldsmith MikeGoldsmith removed the status: info needed Further information is requested. label Sep 21, 2023
@MikeGoldsmith MikeGoldsmith added the status: revision needed Waiting for response to changes requested. label Sep 21, 2023
@MikeGoldsmith
Copy link
Contributor Author

MikeGoldsmith commented Sep 26, 2023

I'm gonna close this for now. We can revisit once we start to get feedback the agent isn't fast enough.

I've opened the following issue to track adding AFPAcket support:

@MikeGoldsmith MikeGoldsmith deleted the mike/afpacket branch September 26, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: revision needed Waiting for response to changes requested. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants