refactor(swift): Use BatchSpanProcessor instead of SimpleSpanProcessor #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkanal
force-pushed
the
purvi/use-batch-spanprocessor
branch
from
2204ab8
to
1e94ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Use
BatchSpanProcessorinstead ofSimpleSpanProcessorsince it is the recommended span processor to use in production apps.Leaving this in draft to start because this might affect smoke tests since it might take a few seconds for the spans to batch send with this change so we might need to add in a wait mechanism.
Short description of the changes
BatchSpanProcessorfrom OTel as the default span processor to send spans.How to verify that this has the expected result