Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(circleci): update config.yml for nightly workflow and build jobs #13

Merged
merged 3 commits into from
Sep 24, 2024
Merged

chore(circleci): update config.yml for nightly workflow and build jobs #13

merged 3 commits into from
Sep 24, 2024

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Sep 24, 2024 •
edited
Loading

Which problem is this PR solving?

Updates CircleCI to have two workflows:

  • nightly cron workflow that runs tests and lint
  • build workflow that runs on every PR and on main, runs tests and lint

Short description of the changes

  • Updated CircleCI config to have multiple workflows
  • Updated GitHub repo to require build to pass to allow merging on a PR

@pkanal pkanal marked this pull request as ready for review September 24, 2024 19:20
@pkanal pkanal requested a review from a team September 24, 2024 19:21
beekhc
beekhc approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@beekhc beekhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@beekhc beekhc merged commit c2d086b into main Sep 24, 2024
6 checks passed
@beekhc beekhc deleted the purvi/lint-tests-on-prs branch September 24, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhc beekhc beekhc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkanal @beekhc