Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(swift): update for new swift format #8

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

beekhc
Copy link
Collaborator

@beekhc beekhc commented Sep 17, 2024

Which problem is this PR solving?

Updates the Makefile and instructions for running swift format.

Short description of the changes

As of Xcode 16, released this week, swift format is now included automatically with Xcode. This is now the recommended way to run what was previously released as swift-format and had to be installed with brew.

While it would be technically possible to write a script to automatically detect swift-format vs swift format, the complexity would not be worth the hassle, as it's recommended to use the latest version of Xcode anyway.

This has the nice side effect that it should fix our circleci lint checks.

How to verify that this has the expected result

make lint
make format


@beekhc beekhc requested a review from a team September 17, 2024 23:11
Copy link

@wolfgangcodes wolfgangcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@beekhc beekhc merged commit f10421f into main Sep 19, 2024
3 checks passed
@beekhc beekhc deleted the beeklimt.update-format branch September 19, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants