fix(macOS): make SDK build in macOS #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangcodes
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This adds annotations to make the SDK work in macOS.
Short description of the changes
Supporting macOS is not a priority for us, but it's nice to have. I'm currently using it to simulate some data from a command-line app. All it takes is a few annotations, so I think it's worth doing.
Note that the diff looks a lot more complicated than the actual changes. GitHub seems to be confused about some indentation changes.
How to verify that this has the expected result
It's not worth adding a test for this at this time. But I have manually verified it by using the SDK.