This code is not needed.

honeycombio · Oct 16, 2024 · 67a0691 · 67a0691
1 parent 06d05ad
commit 67a0691
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/packages/honeycomb-opentelemetry-web/examples/hello-world-web/index.js b/packages/honeycomb-opentelemetry-web/examples/hello-world-web/index.js
@@ -27,7 +27,8 @@ const main = () => {
     webVitalsInstrumentationConfig: {
       vitalsToTrack: ['CLS', 'FCP', 'FID', 'INP', 'LCP', 'TTFB'],
       lcp: {
-        dataAttributes: ['hello', 'barBiz'],
+        reportAllChanges: true,
+        dataAttributes: ['foo'],
       },
     },
   });

diff --git a/packages/honeycomb-opentelemetry-web/src/web-vitals-autoinstrumentation.ts b/packages/honeycomb-opentelemetry-web/src/web-vitals-autoinstrumentation.ts
@@ -501,16 +501,6 @@ export class WebVitalsInstrumentation extends InstrumentationAbstract {
         }
       }
     }
-    if (dataAttributes)
-      dataAttributes?.forEach((attrName) => {
-        const attrValue = el.dataset[attrName];
-        if (attrValue !== undefined) {
-          span.setAttribute(
-            `${attrPrefix}.element.data.${attrName}`,
-            attrValue,
-          );
-        }
-      });
 
     if (applyCustomAttributes) {
       applyCustomAttributes(lcp, span);