fix: This code duplicated not needed. #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangcodes
force-pushed
the
wg/extra-code-lcp
branch
3 times, most recently
from
80b2018
to
06a2c18
Compare
wolfgangcodes
force-pushed
the
wg/extra-code-lcp
branch
from
06a2c18
to
5a07bd4
Compare
arriIsHere
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
This is the original implementation for adding data attributes. it was not removed we updated to use the
datasetAPI.How to verify that this has the expected result
Use the test apps to ensure that the data attributes are still being attached to spans.