Skip to content

Commit

Permalink
Limit external paths to actually necessary for sending telemetry or v…
Browse files Browse the repository at this point in the history
…alidating the configuration (#15)

Signed-off-by: Davin Taddeo <[email protected]>
  • Loading branch information
tdarwin authored Aug 15, 2024
1 parent b20c296 commit 92fb169
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/eu1-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,12 @@ jobs:
--set ingress.annotations."alb\.ingress\.kubernetes\.io/certificate-arn"="${{ secrets.EU1_ACM_ARN }}" \
--set ingress.annotations."external-dns\.alpha\.kubernetes\.io/hostname"="${{ secrets.EU1_DNS_NAME }}" \
--set ingress.hosts[0].host="${{ secrets.EU1_DNS_NAME }}" \
--set ingress.hosts[1].host="${{ secrets.EU1_DNS_NAME }}" \
--set ingress.hosts[2].host="${{ secrets.EU1_DNS_NAME }}" \
--set grpcIngress.annotations."alb\.ingress\.kubernetes\.io/certificate-arn"="${{ secrets.EU1_ACM_ARN }}" \
--set grpcIngress.annotations."external-dns\.alpha\.kubernetes\.io/hostname"="${{ secrets.EU1_DNS_NAME }}" \
--set grpcIngress.hosts[0].host="${{ secrets.EU1_DNS_NAME }}" \
--set grpcIngress.hosts[1].host="${{ secrets.EU1_DNS_NAME }}" \
--set grpcIngress.hosts[2].host="${{ secrets.EU1_DNS_NAME }}" \
--set config.Network.HoneycombAPI="https://api.eu1.honeycomb.io" \
--wait --debug
4 changes: 4 additions & 0 deletions .github/workflows/refinery-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ jobs:
--set ingress.annotations."alb\.ingress\.kubernetes\.io/certificate-arn"="${{ secrets.US1_ACM_ARN }}" \
--set ingress.annotations."external-dns\.alpha\.kubernetes\.io/hostname"="${{ secrets.US1_DNS_NAME }}" \
--set ingress.hosts[0].host="${{ secrets.US1_DNS_NAME }}" \
--set ingress.hosts[1].host="${{ secrets.US1_DNS_NAME }}" \
--set ingress.hosts[2].host="${{ secrets.US1_DNS_NAME }}" \
--set grpcIngress.annotations."alb\.ingress\.kubernetes\.io/certificate-arn"="${{ secrets.US1_ACM_ARN }}" \
--set grpcIngress.annotations."external-dns\.alpha\.kubernetes\.io/hostname"="${{ secrets.US1_DNS_NAME }}" \
--set grpcIngress.hosts[0].host="${{ secrets.US1_DNS_NAME }}" \
--set grpcIngress.hosts[1].host="${{ secrets.US1_DNS_NAME }}" \
--set grpcIngress.hosts[2].host="${{ secrets.US1_DNS_NAME }}" \
--wait --debug
12 changes: 10 additions & 2 deletions refinery-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,11 @@ ingress:
kubernetes.io/ingress.class: alb
hosts:
- host: _replaceme_
path: /
path: /1/
- host: _replaceme_
path: /v1/
- host: _replaceme_
path: /query/
labels: {}

grpcIngress:
Expand All @@ -251,5 +255,9 @@ grpcIngress:
kubernetes.io/ingress.class: alb
hosts:
- host: _replaceme_
path: /
path: /1/
- host: _replaceme_
path: /v1/
- host: _replaceme_
path: /query/
labels: {}

0 comments on commit 92fb169

Please sign in to comment.