feat : 게시판 단건조회 기능 구현 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -26,7 +26,7 @@ public static Long getCurrentUserId() { | |||
| } | |||
|
|
|||
| public User getUser() { | |||
| return userRepository.findById(getCurrentUserId()).orElseThrow(()-> UserNotFoundException.EXCEPTION); | |||
| return userRepository.findById(1L).orElseThrow(()-> UserNotFoundException.EXCEPTION); | |||
There was a problem hiding this comment.
해당 코드는 롤백해주셔야할 것 같습니다.
테스트로 만들어 드렸던건데 같이 들어간거 같아요
| @@ -43,7 +43,7 @@ public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Excepti | |||
| .authorizeHttpRequests(authorization -> authorization | |||
| .requestMatchers( | |||
| "/login", | |||
| "/register", "/health").permitAll() | |||
| "/register", "/health", "/file/**").permitAll() | |||
There was a problem hiding this comment.
/file/**의 경우 사용자만 사용가능한 영역이어야 하기 떄문에 permitAll에 두면 안될 것 같습니다.
제가 테스트로 보여드리느라 추가했던 코드라서 롤백해주셔야 할 것 같아요 :)
donsonioc2010
approved these changes
Oct 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
게시판 단건조회 기능 구현