[FEATURE] 이메일 인증 기능 구현 #37 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jwt필터 코드수정 (React연동 회원가입 후 토큰발급문제 수정)
- jwt필터 코드 다시 수정 (React연동 회원가입 후 토큰발급문제 수정)햣
Comment on lines
63
to
71
| public String generateVerificationLink(User user) { | ||
| String verificationToken = generateUniqueToken(); | ||
|
|
||
| user.activeStatus(); | ||
| userRepository.save(user); | ||
|
|
||
| return "http://localhost:8080/mail/verify?token=" + verificationToken; | ||
| } | ||
|
|
There was a problem hiding this comment.
여기서 localhost를 직접 지정해주게 될 경우에는 개발서버로 배포를 할 시 사용을 못하게 됩니다.
Dynamic하게 변경하기 위해 application-local, application-dev로 분할하여 주입받으시기 바랍니다.
또한 해당 클래스는 메일발송만을 위한 유틸리티 클래스 이기 떄문에 사용자 인증을 위한 유틸리티는 따로 분리가 필요해 보입니다.
| request.getEmail(), | ||
| "이메일 인증 링크를 클릭하여 이메일 인증을 완료하세요", | ||
| "mail/verificationEmail", | ||
| Map.of("verificationLink", sendMailUtil.generateVerificationLink(user)) |
There was a problem hiding this comment.
generateVerificationLink메소드의 경우 MailHelper클래스에서 private Method로 제작한 이후에 this.generateVerificationLink(user) 방식으로 사용하는게 좋을 것 같습니다.
sendMailUtil은 말그대로 Mail만을 위한 UtilClass이기떄문에 해당 클래스에서 추가하는건 부적적해보입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이메일 인증기능 구현 #37 완료