-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX, FEATURES] 전체 이슈 수정 #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
donsonioc2010
commented
Oct 18, 2023
- 일단 Response Null안나오도록 최대한 수정
- Security Mapping 변경
- Sample Data추가
- UserRequest String으로 들어오는 부분 Enum으로 받을 수 있도록 변경 - UserRequest Type변경으로 인해서, 회원가입 Role지정 방식 변경 - 일반 사용자만 타기 떄문에 Role을 UserRole.USER 고정 - AdminController 사용자 상태변경관련해서 DTO받으면서 RequestBody 안받는 이슈 해결 - 사용자 정보 리스트로 반환하는 메소드 기능 관련해서 UserDTO::from으로 리팩토링
- 게시물 단건, 리스트 조회시 CreatedAt, UpdatedAt 조회 안되는 문제 Fix
- ArticleRequestDto, ReplyResponseDto - Null로 들어가는 값을 전부 채움... - Entity - Article : Enum String변경 - ArticleContent : User관계 제거 - ArticleLike : cascade제거, 해당 Entity는 다른 영속성 전파 필요없슴. - Reply : 속성추가 - ReplyContent : Enum String으로 변경
- MyPage Update시 이메일 변경 불필요하여 제거 - 일반 마이페이지 변경시 썸네일, 이메일 변경제거, 오직 패스워드와 닉네임만 가능하게 - 썸네일로직 수정
1 task
bongsh0112
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
증말증말 고생하셨습니다
Auth 쪽은 제가 오늘 밤에 하겠습니당
나중에 DTO 싹 엎죠
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.