Add and adopt subnet component #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, clean up non-working :::panel admonitions
|
Sorry about the delay - I got to checking on this and we unfortunately cannot merge it when you've got the yarn.lock and packages-lock.json files in there as they break the compile of the docs page. If you repush it without those 2 files then we can easily merge it. Thanks! |
|
No problem! I'll rework it when I get a chance - totally didn't notice I pushed the lock files, my bad :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a subnet component (a tip admonition that explains how to get the subnet IP) and adopts it across most use cases (the only exceptions are other components as I haven't quite gotten around to figuring that out).
In addition, clean up non-working :::panel admonitions in some documents