Skip to content

Commit

Permalink
Merge pull request #37 from ymaheshwari1/#207fedx
Browse files Browse the repository at this point in the history
Updated: the app version to 1.0.0 and readme file(#207fedx)
  • Loading branch information
adityasharma7 authored Feb 3, 2022
2 parents 98a87a7 + 36d6834 commit 52e13fa
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 7 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Ionic CLI - If you don't have the ionic CLI installed refer [official documentat
1. Download the app from [release](https://github.com/hotwax/ionic-sdk/releases) page and extract it.
2. Go to the app directory.
3. Run following command to download dependencies
`npm i
`npm i`
4. Create a `.env` file by taking reference from the `.env.example`.
5. To run the app in browser use the command: `ionic serve`

Expand All @@ -44,7 +44,7 @@ Ionic CLI - If you don't have the ionic CLI installed refer [official documentat

# Firebase Hosting

We are using firebase hosting for the Pre-order app deployment
We are using firebase hosting for the Ionic SDK app deployment
Here are the steps to deploy app on firebase hosting

## Prerequisite
Expand Down Expand Up @@ -86,7 +86,7 @@ Follow following instructions:

1. Fork the repository and clone it locally from the `main` branch. Before starting your work make sure it's up to date with current `main` branch.
2. Pick an issue from [here](https://github.com/hotwax/ionic-sdk/issues). Write in the issue comment that you want to pick it, if you can't assign yourself. **Please stay assigned to one issue at a time to not block others**.
3. Create a branch for your edits. Use the following branch naming conventions: **preorder/issue-number**.
3. Create a branch for your edits. Use the following branch naming conventions: **ionic-sdk/issue-number**.
4. Please add issue number to your commit message.
5. Propose a Pull Request to `main` branch containing issue number and issue title.
6. Use [Pull Request template](https://github.com/hotwax/ionic-sdk/blob/main/.github/PULL_REQUEST_TEMPLATE.md) (it's automatically added to each PR) and fill as much fields as possible to describe your solution.
Expand All @@ -113,4 +113,4 @@ If you have any questions or ideas feel free to join our <a href="https://discor

# The license

Pre-order app is completely free and released under the Apache v2.0 License. Check <a href="https://github.com/hotwax/ionic-sdk/blob/main/LICENSE" target="_blank">LICENSE</a> for more details.
Ionic SDK app is completely free and released under the Apache v2.0 License. Check <a href="https://github.com/hotwax/ionic-sdk/blob/main/LICENSE" target="_blank">LICENSE</a> for more details.
6 changes: 6 additions & 0 deletions changelogs/unreleased/-207fedx.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
title: 'Updated: the app version to 1.0.0 and readme file'
ticket_id: "#207fedx"
merge_request: 37
author: Yash Maheshwari
type: fixed
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ionic-sdk",
"version": "0.0.1",
"version": "1.0.0",
"private": true,
"description": "An Ionic project",
"scripts": {
Expand Down

0 comments on commit 52e13fa

Please sign in to comment.