Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented: modal for gitbook Search functionality (#301) #302

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Jun 18, 2024

Related Issues

#301

Short Description and Why It's Useful

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance

src/components/DxpGitBookSearch.vue Outdated Show resolved Hide resolved
src/components/DxpGitBookSearch.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@ymaheshwari1 ymaheshwari1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add all the static text added here in the locales file of the apps in which this component will be used.

@ymaheshwari1 ymaheshwari1 merged commit 40b819f into hotwax:main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants