Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: added permission check over the 'Go To OMS' button (#270) #318

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

amansinghbais
Copy link
Contributor

@amansinghbais amansinghbais commented Aug 21, 2024

Related Issues

#270

Short Description and Why It's Useful

Added permission check over the 'Go To OMS' button.

Note: I have used Commerce user view permission which is a base permission to access the commerce. Also this permission is used in deciding the email template while reset password email action in employees details page.

Related PR for testing

hotwax/preorder#295

Screenshots of Visual Changes before/after (If There Are Any)

Is the changes contains any breaking change?

If there are any breaking change include those in the release notes file

  • Yes
  • No

Contribution and Currently Important Rules Acceptance

@ravilodhi ravilodhi merged commit 6272cb8 into hotwax:main Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants