Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec changes #8

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Spec changes #8

wants to merge 18 commits into from

Conversation

francinelapid
Copy link

@francinelapid francinelapid commented Feb 14, 2020

Important Notes:

  • Will need to change the name/tag for the release or make a new release that reflects the new download link
    • Release Title: give-3.1
    • Tag: v3.1
  • New defaults reflected in INSTALL file

@francinelapid francinelapid reopened this Mar 11, 2020
Copy link
Contributor

@dmanno dmanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you moved to --with and replaced the clunky block for strict-checks. Please modify "checks" to be more descriptive. ("strictchecks", "strict_checks", or the like). What is really happening is that it forces any giver or taker to have their primary group match their uid (ex. dmanno:dmanno), so maybe even "strict_owner"?

give.spec Outdated Show resolved Hide resolved
@francinelapid francinelapid requested a review from dmanno July 6, 2020 16:03
@dmanno
Copy link
Contributor

dmanno commented Jul 7, 2020

OK, apologies I should have caught this in my first pass. We shouldn't change behavior in terms of default build options, so let's modify to use the --without strict_checks as an option and the default behavior is to use --with strict_checks.

@francinelapid
Copy link
Author

Changed default to have strict_checks enabled. Use --without strict_checks to specify non-strict checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants