-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional water heater elements #421
base: master
Are you sure you want to change the base?
Conversation
… `PowerBurner` elements for water heaters; same elements as exist for furnaces/boilers.
@jmaguire1 Can you look these over and provide feedback? I'm not sure if we should use, e.g., "DirectVent" or "PowerVent" instead. |
Yes, I never heard from anyone at GTI on this. It is a little confusing, but I think the way we'll want to do this: CondensingSystem: If a tank WH, TRUE if UEF > 0.77 (or corresponding EF). If tankless, TRUE if EF (or UEF) > 0.94. Else False. AtmosphericBurner: If tank WH, UEF < 0.64. FALSE for any tankless. to rewrite the code for skinlossfrac here, I think this makes it: if "AtmosphericBurner": What really matters here for whether you fall in the 0.91 category is if there's a flue damper, which I think is true pretty much any time "AtmosphericBurner" is false. Condensing vent a little colder, which is how we ended up with a slightly higher skinlossfrac here. |
Two HPXML WG members lean towards switching to "vented" terminology. |
A good resource from AO Smith: https://www.hotwater.com/info-center/water-heater-venting.html |
Adds
SealedCombustion
,CondensingSystem
,AtmosphericBurner
, andPowerBurner
elements for water heaters; these elements already exist for furnaces/boilers.