Rename TemporalMemory extra to externalPredictiveInputs #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was confusion about what this feature does so I renamed it for clarity.
breznak
previously approved these changes
Jun 18, 2019
breznak
approved these changes
Jun 20, 2019
| @@ -99,6 +99,11 @@ class TemporalMemory : public Serializable | |||
| * @param predictedSegmentDecrement | |||
| * Amount by which segments are punished for incorrect predictions. | |||
| * | |||
| * Note: A good value is just a bit larger than | |||
| * (the column-level sparsity * permanenceIncrement). So, if column-level | |||
There was a problem hiding this comment.
OT: #279 it would be nice to reduce the number of parameters for the algorithms, especially in cases like this where a good-enough value can be derived from other settings. Do you think this would be a reasonable candidate to hard-code?
Pros:
- less space for user to mess up
- faster parm optimizations
Cons: - removes a bit of configurability
There was a problem hiding this comment.
I agree, but here are two more potential issues:
- Is this advice always good? I think it would need further investigation before we remove the parameter in favor of this heuristic.
- We would have to modify every instance of the TM to omit this parameter. It would be a lot of work.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was confusion about what this feature does so I renamed it
for clarity.
See also issue #512.