-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python examples fixes #713
Conversation
getOverlaps has been deprecated
This reverts commit 9c5bd93.
@@ -10,7 +10,7 @@ | |||
from htm.encoders.date import DateEncoder | |||
from htm.bindings.algorithms import SpatialPooler | |||
from htm.bindings.algorithms import TemporalMemory | |||
from htm.algorithms.anomaly_likelihood import AnomalyLikelihood | |||
from htm.algorithms.anomaly_likelihood import AnomalyLikelihood #FIXME use TM.anomaly instead, but it gives worse results than the py.AnomalyLikelihood now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OT: this file is a good place to test and replace the python likelihood with TM.anomaly
. Currently the Likelihood from TM (c++) really gives bad results. #665
instead of assertion, that makes processing pipelines easier.
Line 232/233 throws the following error at this end: This seems to be a side effect from line 194 So maybe line 232/233 should be changed to:
Would that make sense? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you for review, David |
Hi @breznak, Tried again and do get a different error:
Now I am wondering, whether this has to do with the fact that I am using the updated hotgym.py code with the current binary release. I'll give it another try, once a new binary has been released. Sorry for any confusion this might have caused. Sorry for any confusion. |
yes, that would be the case. For now you'll need to build from source to get the fix (see Readme on how to do so), or wait till a new release. |
Fixes #712