Нужно больше функций #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
js/functions.js
Outdated
Comment on lines
2
to
7
| if(string.length <= length){ | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| }; |
There was a problem hiding this comment.
можно сразу вернуть результат сравнения, if/else тут избыточен и блок будет не нужен
просто checkLength = (string, length) => string.length <= length
js/functions.js
Outdated
Comment on lines
20
to
24
| if(newString === invertedString){ | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
аналогично это не нужно
js/functions.js
Outdated
| let numberString = ''; | ||
|
|
||
| for(let i = 0; i <= replacedString.length - 1; i++){ | ||
| if(isNaN(replacedString[i]) === false){ |
There was a problem hiding this comment.
можно упростить if(!isNaN(replacedString[i])
js/functions.js
Outdated
Comment on lines
37
to
39
| if(replacedString[i] < 0){ | ||
| numberString += Math.abs(replacedString[i]); | ||
| } |
There was a problem hiding this comment.
никогда не выполнится, так как мы разбираем строку посимвольно
js/functions.js
Outdated
Comment on lines
44
to
48
| if(numberString === ''){ | ||
| return NaN; | ||
| } | ||
| const number = Number(numberString); | ||
| return number; |
There was a problem hiding this comment.
просто return parseInt(numberString, 10)
Kartaviy-arteom
approved these changes
Dec 11, 2024
Kartaviy-arteom
merged commit cf0dda5
into
htmlacademy-javascript:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Нужно больше функций
💥 https://htmlacademy-javascript.github.io/2506775-kekstagram-2/2/