Add options to display parents and children processes of filtered pro… #1139

yurenchen000 · 2022-11-27T08:18:23Z

This PR based on @ashamza 's work
hishamhm/htop#973 (comment)
#76 (comment)

// co-authors added in commits seem doesn't link to github users

The only thing I did was update the patch to fit the current version code.

…cesses Co-authored-by: yurenchen000 <[email protected]>

vlada-dudr · 2023-01-14T20:31:24Z

Exactly what I wanted. Works good for me.

fasterit · 2023-01-15T17:54:23Z

ProcessList.c

@@ -370,6 +370,16 @@ void ProcessList_collapseAllBranches(ProcessList* this) {
   }
 }

+static void ProcessList_filterChildern(ProcessList *this, pid_t pid, Hashtable *processFilter) {


Typo Childern -> Children

fasterit · 2023-01-15T17:55:51Z

ProcessList.c

+         continue;
+
+      if (this->settings->showChildrenInFilter)
+         ProcessList_filterChildern(this, p->pid, filteredProcesses);


Typo Childern -> Children

fasterit

Very nice work @yurenchen000.
This should have a key binding to be quickly toggled as well. May be Shift-F4 + Ctrl-F4?
(Marked the typo Childern, please fix)

yurenchen000 · 2023-01-15T19:11:07Z

Very nice work @yurenchen000. This should have a key binding to be quickly toggled as well. May be Shift-F4 + Ctrl-F4? (Marked the typo Childern, please fix)

got it, I'll fix typo right now.

but I'm not sure if I can add keybinding for it

BenBE

I think those options should probably be exclusive: Either show parents or children, but showing both does not make any sense with filtering.

ProcessList.c

code style format Co-authored-by: BenBE <[email protected]>

yurenchen000 · 2023-01-16T04:54:13Z

I think those options should probably be exclusive: Either show parents or children, but showing both does not make any sense with filtering.

I think it has practical uses, imagine this scenario:

filter by bash
- view It's parents (ancestors): who opened it, a ssh or tmux
- view It's children (descendants): what's it doing, run vim or some service

// equivalent to viewing its family tree

BenBE · 2023-01-16T07:37:22Z

I was assuming this refered to the whole tree, not just the next level in each direction. In that case having both makes sense.

tanriol

There's a couple of problems with this implementation. Also, I'm a bit worried about growing another thing dealing with process trees completely separate from tree view implementation. Would be nice to share the hard part in some reasonable way.

tanriol · 2023-01-16T13:46:37Z

ProcessList.c

+      Process *p = (Process*) (Vector_get(this->processes, i));
+      if (p->pid != pid && Process_isChildOf(p, pid)) {
+         Hashtable_put(processFilter, p->pid, (void*) 1);
+         ProcessList_filterChildren(this, p->pid, processFilter);


This looks quadratic to me (for every descendant of the target process iterate over all processes/threads). Could we do better?

Do you have an idea how to do better?

Even a single loop over processes with walking up from every process would be better (although it would need some cycle detection too) as it can easily be made worst case linear in the total process number. I personally think something like the tree mode "sort by parent" would be even better, but I'm a bit out of context at the moment and not sure how feasible it would be to share that part instead of reimplementing it.

You could make the hit detection (in subtree/any parent) in O(1) if we tracked some item ranges for nested sets (similar to what Joomla is doing for its menus). Unfortunately, when we tried to implement this in-place while building the tree, this made tree creation kinda slow (O(n²)). One option could be to calculate the nested set ranges on the fly from the Table->displayList based on the indent columns; takes at most O(n*m) with m being the maximum tree depth (which is fixed at 32).

tanriol · 2023-01-16T13:48:57Z

ProcessList.c

+         Hashtable_put(filteredProcesses, p->pid, (void*) 1);
+         ppid = Process_getParentPid(p);
+         p = Hashtable_get(this->processTable, ppid);
+      } while (this->settings->showParentsInFilter && p && p->pid != p->ppid);


As we know from #1017 (which I still need to rebase/reimplement), in some cases two processes may be parents of each other and thus this loop becomes an infinite one.

got it,
I will keep an eye on the progress of that issue

tanriol · 2023-01-16T14:00:16Z

Also, do these options make sense in flat view or are they intended for tree mode only?

yurenchen000 · 2023-01-17T15:14:59Z

I was assuming this refered to the whole tree, not just the next level in each direction. In that case having both makes sense.

@BenBE
agree, use whole tree is my primary usage,
if matched item can highlight it'll perfect

yurenchen000 · 2023-01-17T15:20:43Z

Also, do these options make sense in flat view or are they intended for tree mode only?

@tanriol
yes, The current implementation can filter normally in non-tree view,
But I also think it doesn't make much sense in non-tree view.

Did you mean that limit this functionality to tree view mode,
And figure out a way to reuse the process tree information from the tree view?

BenBE · 2023-10-08T22:39:57Z

Also, do these options make sense in flat view or are they intended for tree mode only?

Depending on the task it can make sense to have this available outside tree view too.

thapakazi · 2024-07-04T11:18:44Z

anyone working on this ?

for now I am achieving similar with:

process_name=tmux; 
watch -n 1 -d "pgrep $process_name | xargs -I {} pstree -p {}"

Add options to display parents and children processes of filtered pro…

0513270

…cesses Co-authored-by: yurenchen000 <[email protected]>

yurenchen000 mentioned this pull request Nov 27, 2022

Feature Request: Filter to show only certain sub tree(s) #76

Open

BenBE added the new feature Completely new feature label Nov 28, 2022

fasterit reviewed Jan 15, 2023

View reviewed changes

fasterit requested changes Jan 15, 2023

View reviewed changes

Fix typo: ProcessList_filterChildren

0c775f6

yurenchen000 requested a review from fasterit January 16, 2023 00:07

BenBE reviewed Jan 16, 2023

View reviewed changes

ProcessList.c Show resolved Hide resolved

Update ProcessList.c

86d5d07

code style format Co-authored-by: BenBE <[email protected]>

tanriol suggested changes Jan 16, 2023

View reviewed changes

BenBE mentioned this pull request Oct 7, 2023

With --tree and --pid, show subtrees of given PIDs #1311

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add options to display parents and children processes of filtered pro… #1139

Add options to display parents and children processes of filtered pro… #1139

yurenchen000 commented Nov 27, 2022 •

edited

Loading

vlada-dudr commented Jan 14, 2023

fasterit Jan 15, 2023

yurenchen000 Jan 15, 2023

fasterit Jan 15, 2023

yurenchen000 Jan 15, 2023

fasterit left a comment

yurenchen000 commented Jan 15, 2023 •

edited

Loading

BenBE left a comment

yurenchen000 commented Jan 16, 2023 •

edited

Loading

BenBE commented Jan 16, 2023

tanriol left a comment •

edited

Loading

tanriol Jan 16, 2023

eMPee584 Oct 8, 2023

tanriol Oct 8, 2023

BenBE Oct 8, 2023

tanriol Jan 16, 2023

yurenchen000 Jan 17, 2023

tanriol commented Jan 16, 2023

yurenchen000 commented Jan 17, 2023 •

edited

Loading

yurenchen000 commented Jan 17, 2023

BenBE commented Oct 8, 2023

thapakazi commented Jul 4, 2024 •

edited

Loading

Add options to display parents and children processes of filtered pro… #1139

Are you sure you want to change the base?

Add options to display parents and children processes of filtered pro… #1139

Conversation

yurenchen000 commented Nov 27, 2022 • edited Loading

vlada-dudr commented Jan 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fasterit left a comment

Choose a reason for hiding this comment

yurenchen000 commented Jan 15, 2023 • edited Loading

BenBE left a comment

Choose a reason for hiding this comment

yurenchen000 commented Jan 16, 2023 • edited Loading

BenBE commented Jan 16, 2023

tanriol left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tanriol commented Jan 16, 2023

yurenchen000 commented Jan 17, 2023 • edited Loading

yurenchen000 commented Jan 17, 2023

BenBE commented Oct 8, 2023

thapakazi commented Jul 4, 2024 • edited Loading

yurenchen000 commented Nov 27, 2022 •

edited

Loading

yurenchen000 commented Jan 15, 2023 •

edited

Loading

yurenchen000 commented Jan 16, 2023 •

edited

Loading

tanriol left a comment •

edited

Loading

yurenchen000 commented Jan 17, 2023 •

edited

Loading

thapakazi commented Jul 4, 2024 •

edited

Loading