Fix average download speed (httpie#1516) #1518
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
DownloadStatus
is finished, it callsProgressDisplay.stop()
, which in turn callsProgressDisplay._print_summary()
Here, in
_print_summary()
, we incorrectly assume thattask.completed
means observed steps, but in fact, when the download finishes, it is equal totask.total
, which leads to issue with incorrect average download speed - no matter where we resume the download process, we always gettask.total
stepsSolution
ProgressDisplay
class by adding aresumed_at
attribute to keep track of the progress that has already been done.ProgressDisplay.stop()
method to passtask.completed - self.resumed_at
instead oftask.completed
Related
Solves the issue #1516