-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NickAkhmetov/CAT-777 Processed Data section #3495
Merged
NickAkhmetov
merged 52 commits into
unified-datasets
from
nickakhmetov/processed-datasets
Aug 20, 2024
Merged
Changes from 40 commits
Commits
Show all changes
52 commits
Select commit
Hold shift + click to select a range
5bab2ee
set up processed data section, pull analysis details out of prov, add…
NickAkhmetov dea3cb2
text styling adjustments to match designs
NickAkhmetov 4d88066
add helper panel, add publication/creation date logic, add tooltips t…
NickAkhmetov ee78c1e
sort the processed data section
NickAkhmetov 7503f55
match table of contents and helper panel behavior
NickAkhmetov e0519ca
only expand published datasets by default, reduce prop drilling via c…
NickAkhmetov c7273ed
switch to 3 line clamp in helper panel
NickAkhmetov e9cebb6
pull in image pyramids into processed data, remove base visualization…
NickAkhmetov a213e72
display dataset relationships for vislifted datasets' pyramids
NickAkhmetov 9dfab45
fix node links
NickAkhmetov 4ce7bc2
error toast on malformed hash
NickAkhmetov ca986f2
workspace menu functionalities
NickAkhmetov ea4289c
no need to collapse internal subsections
NickAkhmetov d4f9097
enable changing processed datasets' versions
NickAkhmetov f706d97
fixes for image pyramid case
NickAkhmetov 96b5424
remove version select from dataset summary spec
NickAkhmetov 043659c
Add tracking and changelog
NickAkhmetov 2ea5fcf
Add old version alert to processed dataset
NickAkhmetov 8a41ab2
improve section href logic and consistency
NickAkhmetov 1a93ad2
fix wording on old version alert, fix convertProvDataToNodesAndEdges …
NickAkhmetov 8cc2eca
bulk data transfer section
NickAkhmetov 6c1622f
collections section
NickAkhmetov 0bbab47
metadata section updates
NickAkhmetov d495020
Merge branch 'unified-datasets' into nickakhmetov/processed-datasets
NickAkhmetov eba2c3b
fixes from first round of review
NickAkhmetov 1d67892
improve bulk data transfer section styling, move contributors to attr…
NickAkhmetov 47052f7
improve lazy-loaded hash handling
NickAkhmetov 5af67df
set up redirects to primary dataset page
NickAkhmetov 1337b06
add organ icons to top, style metadata tabs with proper icon size/color
NickAkhmetov a99287e
add json button, make copy ID icon consistent, remove unnecessary ext…
NickAkhmetov 4b6166c
regular dataset label
NickAkhmetov d2cbbc3
improve text alignment for dataset relationship diagram and rest of s…
NickAkhmetov 21a6a59
set up redirect toast
NickAkhmetov 8344df3
add collapsible detail sections and section icons
NickAkhmetov 96c6ebb
Combine `DetailPageSection` and `SectionHeader` into `CollapsibleDet…
NickAkhmetov 6f8667f
fix specs
NickAkhmetov 4987df4
add icons to other detail pages, simplify attribution
NickAkhmetov 9f9c156
add icons to other detail pages, convert/clean up organ page, hide ac…
NickAkhmetov 91e0fd7
fix missing cdn url errors
NickAkhmetov 81efb7f
mock collapsible detail page section out
NickAkhmetov fb74d02
add explanatory comment to collections section context
NickAkhmetov 1cbc62a
reuse lineclamp component instead of duplicating it
NickAkhmetov ad04b6d
fix barrel imports
NickAkhmetov c71383f
add specs
NickAkhmetov 9008a74
add explanatory comment for publication bulk data transfer section
NickAkhmetov 84dc88b
use vitessce hints instead of assayname
NickAkhmetov 180d146
deduplicate dag prov types
NickAkhmetov 3170a72
hide helper panel if no dataset is currently visible, add animations
NickAkhmetov 70c5c45
type lint fix
NickAkhmetov 38f29b3
CAT-831 Data loading improvements for provenance
NickAkhmetov 2300131
fix test mock
NickAkhmetov 8813366
adjust styles for error tile to match
NickAkhmetov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
- Added processed datasets section to display all visualizations for a given raw dataset. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
context/app/static/js/components/detailPage/AnalysisDetails/AnalysisDetails.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import React from 'react'; | ||
|
||
import { DagProvenanceType } from 'js/components/types'; | ||
import AnalysisDetailsList from './AnalysisDetailsList'; | ||
|
||
interface AnalysisDetails { | ||
dagListData: DagProvenanceType[]; | ||
} | ||
|
||
function AnalysisDetails({ dagListData }: AnalysisDetails) { | ||
const ingestPipelines = dagListData.filter((pipeline) => !('name' in pipeline)); | ||
const cwlPipelines = dagListData.filter((pipeline) => 'name' in pipeline); | ||
|
||
return ( | ||
<div> | ||
{ingestPipelines.length > 0 && ( | ||
<AnalysisDetailsList | ||
pipelines={ingestPipelines} | ||
pipelineType="Ingest" | ||
tooltip="Supplementary links for the data ingestion pipelines for this dataset" | ||
/> | ||
)} | ||
{cwlPipelines.length > 0 && ( | ||
<AnalysisDetailsList | ||
pipelines={cwlPipelines} | ||
pipelineType="CWL" | ||
tooltip="Supplementary links for the CWL (Common Workflow Language) pipelines for this dataset" | ||
/> | ||
)} | ||
</div> | ||
); | ||
} | ||
|
||
export default AnalysisDetails; |
2 changes: 1 addition & 1 deletion
2
...tailsLink/ProvAnalysisDetailsLink.spec.js → ...lysisDetails/AnalysisDetailsLink.spec.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this into the
Dataset
type?