Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NickAkhmetov/CAT-977 Revise Collection DOI links to copy on click #3589

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

NickAkhmetov
Copy link
Collaborator

Summary

This PR adjusts the collection page DOI links to copy on click instead of opening a new tab to the same page and removes the duplicated DOI link at the top of the page. Future self-referential DOI's can also be marked with an internalDOI prop.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-977

Testing

Manually tested with the collection page linked in the ticket.

Screenshots/Video

Before:

image

After:
image

Copy toast:
image

Checklist

  • Code follows the project's coding standards
    • Lint checks pass locally
    • New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
  • Unit tests covering the new feature have been added
  • All existing tests pass
  • Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
  • Any new functionalities have appropriate analytics functionalities added

Additional Notes

austenem
austenem previously approved these changes Nov 1, 2024
Copy link
Collaborator

@austenem austenem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat fix, I like the internal/external component solution!

john-conroy
john-conroy previously approved these changes Nov 1, 2024
Copy link
Collaborator

@john-conroy john-conroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Potentially a little confusing since it still is a link visually and while we, with knowledge of the system, know the link is self-referential, outside users might not.

@NickAkhmetov
Copy link
Collaborator Author

An explanatory tooltip wouldn't hurt 👌

@NickAkhmetov NickAkhmetov merged commit 73ec064 into main Nov 4, 2024
8 checks passed
@NickAkhmetov NickAkhmetov deleted the nickakhmetov/cat-977 branch November 4, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants