NickAkhmetov/CAT-736 Convert sample detail page to TSX #3592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR converts the sample detail page to TypeScript. Minimal changes were necessary, as most detail page components were converted during the unified dataset detail page push.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-736
Testing
I viewed several sample pages without encountering errors.
Screenshots/Video
N/A
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
I wonder if we can enhance the EUI links on sample pages to link directly to the sample in question, e.g.: https://portal.hubmapconsortium.org/browse/sample/e5f2cb399e7e8885134c1b1a2b6acc9a
The ccf eui link in the tissue section just takes the user to the main ccf eui page in the portal, i.e. https://portal.hubmapconsortium.org/ccf-eui; it seems like it would be a relatively straightforward enhancement for us to pass in a URL param to preselect the appropriate sample since it's not clear how one would find the sample in the EUI otherwise.