Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes space link in gradio blocks events page #614

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

dawoodkhan82
Copy link
Contributor

No description provided.

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MKhalusova
Copy link
Contributor

The change looks good to me, but I wonder why doc_builder fails. cc @mishig25 any ideas?

@osanseviero
Copy link
Contributor

From https://github.com/huggingface/course/actions/workflows/build_pr_documentation.yml it seems i'ts been broken for some weeks 🤔

@dawoodkhan82 dawoodkhan82 changed the title Fixes space link to gradio blocks events page Fixes space link in gradio blocks events page Sep 19, 2023
@MKhalusova
Copy link
Contributor

@osanseviero it must be some specific issue, because it was working on other PRs last week.

@mishig25
Copy link
Contributor

Doc-build will work after rebasing from main (specifically, this change #618)

Copy link
Contributor

@mishig25 mishig25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mishig25 mishig25 merged commit d1ff989 into main Sep 24, 2023
1 of 2 checks passed
@mishig25 mishig25 deleted the blocks-events-link branch September 24, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants