-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GGMLFileQuantizationType and apply to test #806
feat: add GGMLFileQuantizationType and apply to test #806
Conversation
cc @ngxson too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I added the The reason is because many operations in ggml only support F32 for 1d tensors. So in fact, gguf file is never "purely" quantized, but rather being a mix between quantized type and F32. |
BTW, i also propose to display the enum's key name in a tooltip inside the GGUF file viewer, like this: |
i'll let you merge @ngxson! |
Yeah I linked to the incorrect file, but the content is not changed anyway because I only added |
@mishig25 that's it for #794