Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GGMLFileQuantizationType and apply to test #806

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

snowyu
Copy link
Contributor

@snowyu snowyu commented Jul 17, 2024

@mishig25 that's it for #794

@julien-c
Copy link
Member

cc @ngxson too

Copy link
Member

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks 👍

Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will let @mishig25 do a final review and merge 👌

Thanks a lot @snowyu!

@ngxson
Copy link
Member

ngxson commented Aug 16, 2024

FYI, I added the MOSTLY_ prefix in the last commit, to better reflect the type name from ggml (see here)

The reason is because many operations in ggml only support F32 for 1d tensors. So in fact, gguf file is never "purely" quantized, but rather being a mix between quantized type and F32.

@julien-c
Copy link
Member

BTW, i also propose to display the enum's key name in a tooltip inside the GGUF file viewer, like this:

image

(internal PR)

@julien-c
Copy link
Member

i'll let you merge @ngxson!

@ngxson ngxson merged commit 1140e0c into huggingface:main Aug 16, 2024
4 checks passed
@snowyu
Copy link
Contributor Author

snowyu commented Aug 17, 2024

@ngxson be careful, the const is not in ggml.h, it's in llama.h.

@ngxson
Copy link
Member

ngxson commented Aug 17, 2024

Yeah I linked to the incorrect file, but the content is not changed anyway because I only added MOSTLY_ on top of your commit. (So everything is still correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants