Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logincache docs #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove logincache docs #59

wants to merge 1 commit into from

Conversation

Joannis
Copy link
Member

@Joannis Joannis commented Sep 30, 2024

No description provided.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bit of chicken and egg here. I can't merge this until the identity changes are in a released build but of course the documentation is out of date with latest code so will generate errors.

@@ -63,7 +63,7 @@ router.middlewares.add(BasicAuthenticator())
router.middlewares.add(IsAuthenticatedMiddleware<User>())
```

Or you can use ``HummingbirdAuth/LoginCache/require(_:)`` to access the authentication data. In both of these cases if data is not available a unauthorised error is thrown and a 404 response is returned by the server.
Or you can use ``AuthRequestContext/identity-swift.property`` to access the authenticated identity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HummingbirdAuth/AuthRequestContext?

How does the identity-swift.property work? I've not seen that before. identity should be enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what Xcode completes it with

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants