Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptors(pwm): introduce scale option for servo #1046

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Dec 5, 2023

Solved issues and/or description of the change

fix #692 and a step for #1032 , this means:

  • option for change range of duty-cycle (pin specific)
  • option for change range of angle (pin specific)
  • option to change default period (pin specific)

additionally:

  • change architecture for existing PWM options to the "applier" (see aio and gpio implementations), away from func(option) architecture.
  • improve PWM related tests for all platforms

Manual test

  • OS and Version (Win/Mac/Linux): tinkerboard
  • Adaptor(s) and/or driver(s):
    • motor
    • servo

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a changed driver or adaptor:

  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

@gen2thomas gen2thomas marked this pull request as ready for review December 5, 2023 19:26
@gen2thomas gen2thomas merged commit 8ae4667 into hybridgroup:dev Dec 5, 2023
5 checks passed
@gen2thomas gen2thomas deleted the feature/min_max_servo branch December 5, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant