Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ble(client): add scan timout and configure option #1051

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jan 6, 2024

Solved issues and/or description of the change

If there is no BLE device, the connect procedure will never stop. This change adds a timeout and the possibility to configure the timeout by With* option.

Additionally:

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): client-adaptor

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas force-pushed the feature/ble_test branch 2 times, most recently from b67a662 to 5df431b Compare January 29, 2024 18:27
@gen2thomas gen2thomas force-pushed the feature/ble_test branch 15 times, most recently from 7b564ed to f4c756e Compare February 11, 2024 15:07
@gen2thomas gen2thomas marked this pull request as ready for review February 11, 2024 16:00
@gen2thomas gen2thomas merged commit 9430005 into hybridgroup:dev Feb 11, 2024
6 checks passed
@gen2thomas gen2thomas deleted the feature/ble_test branch February 11, 2024 16:01
szampardi pushed a commit to szampardi/gobot that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant