Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tinkerboard2: introduce adapter for Asus Tinker Board 2 (rk3399) #1108

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Dec 14, 2024

Solved issues and/or description of the change

The gpio and pwn definitions differ from Tinkerboard with rk3288, so a new adaptor was introduced.

Additionally introduce common:

  • analogpintranslator
  • digitalpintranslator
  • pwmpintranslator
  • busnumbervalidator, used for i2c and spi

Additionally:

  • small fixes in logging text
  • small fixes in test function name
  • use the new common translators and validator for, if applicable:
    • beaglebone & pocketbeagle
    • chip
    • dragonboard
    • joule
    • jetson
    • nanopi
    • rasp
    • rockpi
    • up2
    • tinkerboard
    • tinkerboard2

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s):
    • gpio (see new example, tested with all header pins)
    • onewire (DS18B20)
    • i2c (YL-40)
    • pwm (with oscilloscope)

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

@gen2thomas gen2thomas force-pushed the feature/tinkerboard2 branch 2 times, most recently from b7754a0 to 57506b6 Compare December 14, 2024 14:35
@gen2thomas gen2thomas marked this pull request as ready for review December 14, 2024 14:40
@gen2thomas gen2thomas merged commit c1a11a6 into hybridgroup:dev Dec 17, 2024
6 checks passed
@gen2thomas gen2thomas deleted the feature/tinkerboard2 branch December 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant