perf: improve BufList::copy_to_bytes if len == remaining #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried this change. All tests are passing. My observation on production-like traffic: tokio-rs/axum#2381 (reply in thread) |
yanns
approved these changes
Mar 11, 2024
|
Published in http-body-util v0.1.1. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
take(len)costs a bit in performance. If copying the full thing (which is whatCollected::to_bytes()does), we can skip usingtake(n)and see a significant speed up.Using hyper's body benchmarks, on my tiny VM, the perf improvement is from 5GB/s to 31GB/s.