Fix configuration change bug

hyperjump-io · May 20, 2024 · 35a1a35 · 35a1a35
1 parent bd66901
commit 35a1a35
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/language-server/src/features/document-settings.js b/language-server/src/features/document-settings.js
@@ -1,5 +1,6 @@
 import { DidChangeConfigurationNotification } from "vscode-languageserver";
 import { publish } from "../pubsub.js";
+import { clearSchemaDocuments } from "./schema-documents.js";
 
 
 export const isSchema = RegExp.prototype.test.bind(/(?:\.|\/|^)schema\.json$/);
@@ -23,11 +24,12 @@ export default {
     connection.onDidChangeConfiguration((change) => {
       if (hasConfigurationCapability) {
         documentSettings.clear();
+        clearSchemaDocuments();
       } else {
         globalSettings = change.settings.jsonSchemaLanguageServer ?? globalSettings;
       }
 
-      publish("workspaceChange", { changes: [] });
+      publish("workspaceChanged", { changes: [] });
     });
 
     documents.onDidClose(({ document }) => {

diff --git a/language-server/src/features/schema-documents.js b/language-server/src/features/schema-documents.js
@@ -30,3 +30,5 @@ export const getSchemaDocument = async (connection, textDocument) => {
 
   return schemaDocument;
 };
+
+export const clearSchemaDocuments = () => schemaDocuments.clear();
diff --git a/language-server/src/features/workspace.js b/language-server/src/features/workspace.js
@@ -9,7 +9,7 @@ import {
   TextDocumentSyncKind
 } from "vscode-languageserver";
 import { TextDocument } from "vscode-languageserver-textdocument";
-import { publishAsync } from "../pubsub.js";
+import { publish, publishAsync, subscribe } from "../pubsub.js";
 import { getSchemaDocument } from "./schema-documents.js";
 import { isSchema } from "./document-settings.js";
 
@@ -47,7 +47,7 @@ export default {
       // eventType === "rename" means file added or deleted (on most platforms?)
       // eventType === "change" means file saved
       // filename is not always available (when is it not available?)
-      validateWorkspace({
+      publish("workspaceChanged", {
         changes: [
           {
             uri: filename,
@@ -57,7 +57,7 @@ export default {
       });
     };
 
-    const validateWorkspace = async (_changes) => {
+    subscribe("workspaceChanged", async (_message, _changes) => {
       const reporter = await connection.window.createWorkDoneProgress();
       reporter.begin("JSON Schema: Indexing workspace");
 
@@ -73,7 +73,7 @@ export default {
       }
 
       reporter.done();
-    };
+    });
 
     const validateSchema = async (textDocument) => {
       connection.console.log(`Schema Validation: ${textDocument.uri}`);
@@ -123,7 +123,7 @@ export default {
           watchWorkspace(onWorkspaceChange);
         }
 
-        validateWorkspace({ changes: [] });
+        publish("workspaceChanged", { changes: [] });
       });
     }
 
@@ -135,7 +135,7 @@ export default {
       }
     });
 
-    validateWorkspace({ changes: [] });
+    publish("workspaceChanged", { changes: [] });
   }
 };