-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(contracts): minor token related changes #4580
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4580 +/- ##
==========================================
- Coverage 82.33% 73.80% -8.54%
==========================================
Files 100 100
Lines 1421 1424 +3
Branches 180 182 +2
==========================================
- Hits 1170 1051 -119
- Misses 251 352 +101
- Partials 0 21 +21
|
); | ||
} | ||
|
||
function testRemoteTransfer_rebaseWithCustomHook() public { |
Check failure
Code scanning / Olympix Integrated Security
Modifying state after making an external call may allow for reentrancy attacks. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy Critical test
); | ||
} | ||
|
||
function testRemoteTransfer_rebaseWithCustomHook() public { |
Check notice
Code scanning / Olympix Integrated Security
Reentrant functions which emit events after making an external call may lead to out-of-order events. For more information, visit: http://detectors.olympixdevsectools.com/article/web3-vulnerability/reentrancy-events Low test
Description
Minor token related changes like adding custom hook to 4626 collateral, checking for ERC20 as valid contract in HypERC20Collateral, etc.
Drive-by changes
check for overflow in bytes32ToAddress
Related issues
Backward compatibility
Yes
Testing
Unit tests