fix(contracts): InterchainAccountRouter minor audit remediation #4581
Conversation
aroralanuk
requested review from
yorhodes,
tkporter and
ltyu
as code owners
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4581 +/- ##
==========================================
+ Coverage 73.89% 73.93% +0.03%
==========================================
Files 100 100
Lines 1421 1427 +6
Branches 180 180
==========================================
+ Hits 1050 1055 +5
- Misses 350 351 +1
Partials 21 21
|
There was a problem hiding this comment.
imo it would be quite simplifying if we just treated this like a normal router
theres not really a big cost of just deploying your own if you cant enroll on an existing set
There was a problem hiding this comment.
but probably not the place to make this change
is hookset not something we can use in the validator if say the merkle hook gets updated in the future? |
| function setHook( | ||
| address _hook | ||
| ) public override onlyInitializing onlyContractOrNull(_hook) onlyOwner { | ||
| hook = IPostDispatchHook(_hook); | ||
| } |
There was a problem hiding this comment.
I dont agree that this should be onlyInitializing
| _router, | ||
| _body, | ||
| new bytes(0), | ||
| hook |
Description
Drive-by changes
Related issues
Backward compatibility
No
Testing
Unit tests