feat: better chain selection concept #4596
Conversation
…ectionStep function
…MultiChainSelectionStepOptions object instead of a list of params
…to xeno/better-chain-selection-concept
🦋 Changeset detectedLatest commit: 15c7df3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4596 +/- ##
=======================================
Coverage 73.89% 73.89%
=======================================
Files 100 100
Lines 1421 1421
Branches 180 180
=======================================
Hits 1050 1050
Misses 350 350
Partials 21 21
|
There was a problem hiding this comment.
Great progress. I love that you thought about other potential use cases. my feedback is generally, I would prefer to keep thing simpler, until we need them
for example, i noticed that there are multiple help modes, but 1) it's unclear how to use them, and 2) if we'll ever need them because we only use always in runMultiChainSelectionStep
| return key.name === 'down'; | ||
| } | ||
|
|
||
| export const searchableCheckBox = createPrompt( |
There was a problem hiding this comment.
I can't really tell that i'm able to search, until i start typing. Is there a good way to let the user know that it's searchable?
There was a problem hiding this comment.
Adding a hint to the help message should be okay I think. We already do the same for telling the user to use tabs to select and enter to complete the selection. Examples:
Before
After
| checkboxTheme, | ||
| config.theme, | ||
| ); | ||
| const firstRender = useRef(true); |
There was a problem hiding this comment.
So strange to see these react hooks here. I wondered if inquirer was using react under the hood but actually they implemented these themselves! https://github.com/SBoudrias/Inquirer.js/blob/main/packages/core/src/lib/use-memo.ts
There was a problem hiding this comment.
I was surprised at first too! Then I looked at the package code and saw that they implemented their own. super cool!
|
Mostly looks good to me so far! |
Description
This PR implements an updated view of the multi-chain selection step that now allows searching for chains in the current list
Before:
After:
Drive-by changes
runMultiChainSelectionStepfunction to take as param an object instead of a list of params because the list was growing largerRelated issues
Backward compatibility
Testing
gitbash.powershellandcmd. I assume the issue is linked to howgitbashhandles inputs or simulates a UNIX environment on Windows. CLI users on windows should use either one of these options